[SpinBox] Set renderType
ClosedPublic

Authored by broulik on Jul 17 2019, 10:16 AM.

Details

Summary

Ensures it uses the system's font rendering settings

BUG: 409888

Test Plan

Fonts KCM still works fine, didn't actually test the anti aliasing setings mentioned in the bug

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 17 2019, 10:16 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 17 2019, 10:16 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 17 2019, 10:16 AM
ngraham accepted this revision.Jul 17 2019, 3:52 PM
This revision is now accepted and ready to land.Jul 17 2019, 3:52 PM
apol added a subscriber: apol.Jul 18 2019, 12:33 PM
apol added inline comments.
org.kde.desktop/SpinBox.qml
69

Should that be the case for every TextInput then? why's the SpinBox special?

broulik added inline comments.Jul 18 2019, 12:36 PM
org.kde.desktop/SpinBox.qml
69

It should. It was already done for ComboBox and TextField but SpinBox got forgotten :)

apol accepted this revision.Jul 18 2019, 12:40 PM

:shrug: well sounds like a fix upstream is due, either fixing nativerendering on non-integer scaling or just doing this everywhere.
Also if it ever gets fixed we'll stay with this workaround until someone remembers to remove.

I want NativeRendering which Qt doesn't do by default. This patch is needed either way, be it true or that annoying workaround. If someone with shader knowledge could fix the native rendering shader that would be lovely, yes.

This revision was automatically updated to reflect the committed changes.