Pass arguments to changeMaximize in correct order
ClosedPublic

Authored by zzag on Jul 16 2019, 11:16 AM.

Details

Summary

The first argument in AbstractClient::changeMaximize specifies whether
the maximized state of the client needs to be toggled in horizontal
direction.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 16 2019, 11:16 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 16 2019, 11:16 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 16 2019, 11:16 AM
zzag added a comment.Jul 16 2019, 11:19 AM

Currently, the wrong argument order doesn't have any impact, but once we implement "Maximized only Horizontally/Vertically" pseudo-states in (Xdg)ShellClient, this will bite us.

romangg accepted this revision.Mon, Jul 22, 8:28 PM
This revision is now accepted and ready to land.Mon, Jul 22, 8:28 PM
This revision was automatically updated to reflect the committed changes.