Add a Settings() for golfSolverIterationsLimit.
AcceptedPublic
Actions

Authored by shlomif on Jul 15 2019, 9:20 PM.

Details

Reviewers

aacid

Group Reviewers

KDE Games

Summary

Add a test for golf solver wins.

Settings() Curently not exposed to the GUI AFAIK. It is useful if you have
more/less CPU or RAM.

Optimize by imcreasing the CHUNKSIZE.

Repository

R410 KPatience

Branch

solver-iters-limit-settings

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14621
Build 14639: arc lint + arc unit

Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript

shlomif requested review of this revision.Jul 15 2019, 9:20 PM

aacid added inline comments.

patsolve/golfsolver.cpp
211	i'd be happied if default_max_solutions was initialized here to something Doesn't need to be the settings value, but i just want it to be clear that it's never used uninitalized

This revision is now accepted and ready to land.Aug 8 2019, 10:07 PM

		Path
M		autotests/CMakeLists.txt (7 lines)
A	M	autotests/golf_solver_wins.cpp (47 lines)
M		golf.cpp (5 lines)
M		kpat.kcfg (3 lines)
M		patsolve/golfsolver.h (1 line)
M		patsolve/golfsolver.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61832	b71dc64		Jul 15 2019, 9:20 PM	★	★
Diff 2	62873	b71dc64	- Initialize to a default value.	Jul 31 2019, 7:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bb519e9bcc4b	ef0c10f8a2c5	15bd54694a57	Shlomi Fish	Initialize to a default value.	Jul 31 2019, 7:01 PM
15bd54694a57	5d35f3a32575	addf45a3455e	Shlomi Fish	Optimize by imcreasing the CHUNKSIZE. (Show More…)	Jul 15 2019, 9:17 PM
addf45a3455e	5f9e7d102af0	063fb4d6b828	Shlomi Fish	Add a Settings() for golfSolverIterationsLimit. (Show More…)	Jul 15 2019, 8:50 PM
063fb4d6b828	0b2dc4444dec	b71dc64ee540	Shlomi Fish	Add a test for golf solver wins.	Jul 15 2019, 8:35 PM