Use metadata.json when creating the metadata from KPackage::metadata()
ClosedPublic
Actions

Authored by apol on Jul 15 2019, 3:19 PM.

Details

Reviewers

None

Group Reviewers

Frameworks

Commits

Summary

Otherwise we'd end up using the slow path.

Test Plan

metadata still gets loaded but using the faster path.

Repository

R290 KPackage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

apol requested review of this revision.Jul 15 2019, 3:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 15 2019, 7:38 PM

This revision was automatically updated to reflect the committed changes.

That was less than 5 hours from posting to give up on a review!

We're not in a rush.

src/kpackage/package.cpp
52	that's a whitelist
64	According to the docs Starting in 4.6, if an entry with the given key already exists, the path is added to it as a search alternative. so we can also search for metadata.json without changing the key. which will then work for all other code that uses "metadata" as a key.

In D22475#496132, @davidedmundson wrote:

That was less than 5 hours from posting to give up on a review!

We're not in a rush.

Ugh yeah, I didn't mean to land the patch. >.<

			Path	Packages
M			src/kpackage/package.cpp (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61797	c74ec36		Jul 15 2019, 3:19 PM	★	★
Diff 2	61827	c74ec36	R290:898e5133e79659e463cf16bfeadd576f53669dd5	Jul 15 2019, 3:19 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
93d7db10a160	0a18a3bd82ef	c74ec3611d47	Aleix Pol	Use metadata.json when creating the metadata from KPackage::metadata() (Show More…)	Jul 15 2019, 3:18 PM