Make captive portal notification persistent but low priority

Authored by ngraham on Jul 15 2019, 12:46 AM.



The captive portal notification is something that shouldn't time out; when it
becomes visible, it's something the user needs to interact with. I had a
frustrating experience just now trying and failing to click on it before it timed

At the same time, once it's interacted with (either by closing it or clicking the
"Log in" button) there's no need for it to appear in the history, as its history
item is both non-informative and non-interactive.

Accordingly, this patch makes the captive portal notification both persistent and
low urgency (so it doesn't appear in the history).

A similar thing has already been done for Discover in D22429.

Test Plan

Connected to the in-flight wifi network on the plane I'm on right now
Captive Portal notification was persistent and didn't show up in the history
after dismissed or logged into via the button on the notification pop-up

Diff Detail

R116 Plasma Network Management Applet
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jul 15 2019, 12:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 15 2019, 12:46 AM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 15 2019, 12:46 AM
apol added a subscriber: apol.Jul 15 2019, 1:25 AM


Makes sense to me. I added a similar feature to work around the disappearing notification few weeks ago.

ngraham edited the summary of this revision. (Show Details)Jul 15 2019, 1:30 AM
jgrulich accepted this revision.Jul 15 2019, 4:28 AM
This revision is now accepted and ready to land.Jul 15 2019, 4:28 AM
This revision was automatically updated to reflect the committed changes.