Differential D22466

servicemenuinstaller: Run installation scripts with cwd in their parent directories
ClosedPublic
Actions

Authored by aspotashev on Jul 14 2019, 11:44 PM.

Details

Reviewers
elvisangelaccio
sitter
Commits
R318:f523585f1be5: servicemenuinstaller: Run installation scripts with cwd in their parent…
Summary

Otherwise, if cwd is set to the unpacked dir root, some service menus
fail to install.

Test Plan
  • Successfully Installed and uninstalled the "Color Folder" service menu from "Configure Dolphin..." -> service menus -> KNewStuff.
  • ./test_run.rb still passes all its tests.

Diff Detail

Repository
R318 Dolphin
Branch
fix-cwd
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13954
Build 13972: arc lint + arc unit
aspotashev created this revision.Jul 14 2019, 11:44 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJul 14 2019, 11:44 PM
Restricted Application edited subscribers, added: kfm-devel; removed: Dolphin. · View Herald Transcript
aspotashev requested review of this revision.Jul 14 2019, 11:44 PM
sitter added a comment.Jul 15 2019, 1:56 PM

Did this case not have a test? Shouldn't it be getting one if it didn't have one?

aspotashev updated this revision to Diff 61823.Jul 15 2019, 7:14 PM
  • servicemenuinstaller test: Make sure uninstall script is run from its parent dir
aspotashev updated this revision to Diff 61824.Jul 15 2019, 7:17 PM
  • servicemenuinstaller test: Make sure uninstall script is run from its parent dir
sitter accepted this revision.Jul 16 2019, 9:20 AM

fix it then shipit

src/settings/services/test/service_menu_deinstallation_test.rb
23 ↗(On Diff #61823)

sort alphabetically please

This revision is now accepted and ready to land.Jul 16 2019, 9:20 AM
aspotashev marked an inline comment as done.Jul 16 2019, 12:04 PM

Going to push to Applications/19.08

Closed by commit R318:f523585f1be5: servicemenuinstaller: Run installation scripts with cwd in their parent… (authored by aspotashev). · Explain WhyJul 16 2019, 12:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61771

View Options

src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp

Loading...