DrKonqi: improved lldb integration
AcceptedPublic

Authored by rjvbb on Jul 14 2019, 9:09 PM.

Details

Reviewers
kde-frameworks-devel
dfaure
Group Reviewers
Plasma
Summary

Since a few versions lldb has had a tendency to remain stuck after the initial connection to the crashed application (on Mac). On Linux it would often exit cleanly and quickly in a way not foreseen by my previous code, causing DrKonqi to report an unexpected debugger termination.

This patch addresses both issues:

  • recent lldb versions have no more problems with reading commands from a batchfile
  • this make it possible to add an explicit exit command
  • slotProcessExited() is called explicitly when lldb has confirmed the exit command
  • errors caused by terminating or killing the debugger process are now ignored.
Test Plan

Getting a crash backtrace now works as expected on Mac and Linux. No regressions are introduced when using the gdb backend on Linux.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 13944
Build 13962: arc lint + arc unit
rjvbb created this revision.Jul 14 2019, 9:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2019, 9:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rjvbb requested review of this revision.Jul 14 2019, 9:09 PM
dfaure accepted this revision.Jul 20 2019, 6:07 PM
This revision is now accepted and ready to land.Jul 20 2019, 6:07 PM