Convert custom messaging address fields to Impp fields
ClosedPublic
Actions

Authored by vkrause on Jul 14 2019, 7:31 AM.

Details

Reviewers

Commits

R174:a2126a1b12c2: Convert custom messaging address fields to Impp fields

Summary

This does not only allow us to get rid of a lot of error-prone custom
field code in applications, using the designated standard field for this
(standardized in 2007 already!) also makes messaging addresses show up
correctly in Nextcloud for example.

Diff Detail

Repository

R174 KContacts

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Jul 14 2019, 7:31 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 14 2019, 7:31 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Jul 14 2019, 7:31 AM

Harbormaster completed remote builds in B13917: Diff 61722.Jul 14 2019, 7:31 AM

mlaurent accepted this revision.Jul 14 2019, 9:30 AM

This revision is now accepted and ready to land.Jul 14 2019, 9:30 AM

Closed by commit R174:a2126a1b12c2: Convert custom messaging address fields to Impp fields (authored by vkrause). · Explain WhyJul 15 2019, 4:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	autotests/data/vcard_legacy_messaging_fields.vcf (9 lines)
A	M	autotests/data/vcard_legacy_messaging_fields.vcf.ref (11 lines)
M		autotests/testroundtrip.qrc (2 lines)
M		src/vcardtool.cpp (18 lines)