Check for refocus also during the calibration stage
ClosedPublic

Authored by wreissenberger on Jul 13 2019, 1:24 PM.

Details

Summary

In the Capture module there is an option to re-focus every x minutes. The check whether the selected time has expired, takes place after an image has been taken and there is anotherone in the same sequence. Sequences, that contain only single frames (like a single LRGB sequence) result in the situation, that re-focussing is never started.
To cover such sequences, it is necessary to check before an imaging sequence is started, whether a re-focus is necessary.

Test Plan

Create a capture sequence with a single frame and embed it into a schedule that repeatedly starts it. Select the re-focus option and set the frequency to 1. Without this patch, re-focusing will never be issued. With this patch, re-focusing takes place as expected.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Jul 13 2019, 1:24 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 13 2019, 1:24 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Jul 13 2019, 1:24 PM
mutlaqja accepted this revision.Jul 17 2019, 12:49 PM

Great. Thanks for taking care of this case. Looks good to me!

This revision is now accepted and ready to land.Jul 17 2019, 12:49 PM
TallFurryMan accepted this revision.Jul 17 2019, 1:38 PM

I agree but did not test. I was wondering what the calibration stage was referring to? Is it the same as the calibration for flats?

That's a good point. The calibration stage is for dark/flat/bias pre-capture steps (like parking, going to a wall location, or putting on cap..etc) so maybe this step ought to be elsewhere? so that the two paths are not intermixed?

mutlaqja requested changes to this revision.Jul 17 2019, 3:59 PM
This revision now requires changes to proceed.Jul 17 2019, 3:59 PM

Sorry, the description is misleading, the focus check is added to startNextExposure(). This is exactly the same place where I added the meridian flip check, where we had the same problem.

The calibration itself is untouched.

mutlaqja added inline comments.Jul 17 2019, 8:46 PM
kstars/ekos/capture/capture.h
110 ↗(On Diff #61695)

This enum is for bias/dark/flat pre-capture steps required, so focusing does not belong here.

Re-focusing before capturing reworked, focusing states removed from calibration stages

mutlaqja accepted this revision.Jul 22 2019, 2:00 PM
This revision is now accepted and ready to land.Jul 22 2019, 2:00 PM
This revision was automatically updated to reflect the committed changes.