| elvisangelaccio |
| Dolphin |
After leaving terminal with Ctrl-D or exit commands the input focus isn't set back to the folder view. The problem appears, because TerminalPanel::isHiddenInVisibleWindow
returns not what it supposed to return. I moved unwanted checks from it inside TerminalPanel::dockVisibilityChanged
BUG: 407979
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This issue was supposed to be fixed by commit 4e40fe810d324 but it seems it got reintroduced in the past months.
Could you try to git bisect it to figure out when this happend?
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 754 | This looks like an unrelated change, if it's not can you explain why we need it? | |
It seems that it was not fixed. I can reproduce the problem at 4e40fe810d324.
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 754 | m_activeViewContainer is NULL when Dolphin starts and without this change app crashes. | |
I'd still like to understand what happend at the change in 4e40fe810d324.
@ngraham Any idea?
@elvisangelaccio, I read the description of change in 4e40fe810d324 and bug 298467, which was fixed in it more carefull and understood that the change was supposed to introduce the feature of setting the focus back to the active view. However, it seems that Ctrl-D or exit command cases were not tested good enough.
Right. The fix looks correct to me, going to push it to master (with an improved commit message).
| src/dolphinmainwindow.cpp | ||
|---|---|---|
| 754 | You're right, it was a problem also before and it was working just by luck... | |