[Fonts KCM] Alter DPI only on explicit user interaction
ClosedPublic

Authored by broulik on Jul 11 2019, 1:12 PM.

Details

Summary

The settings are loaded after the QML is created, and once it is loaded, it becomes indeterministic which property (checkbox checked or spinbox value) is re-evaluated first and the Binding ends up resetting the config.

BUG: 405572

Test Plan

Opened Fonts KCM, DPI 192 was properly shown, changed some other font settings, my DPI did not change
Changed font DPI, worked fine. Checking and unchecking also works fine. When unchecking it resets the value to 96

Haven't checked whether this is in 5.16 or only a master regression.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 11 2019, 1:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2019, 1:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 11 2019, 1:12 PM
broulik edited the test plan for this revision. (Show Details)
fvogt added a subscriber: fvogt.Jul 11 2019, 1:22 PM

Haven't checked whether this is in 5.16 or only a master regression.

5.16.3 appears to have the same bug here.

ngraham accepted this revision.Jul 11 2019, 1:33 PM
ngraham edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jul 11 2019, 1:33 PM
bshah accepted this revision.Jul 11 2019, 1:48 PM
This revision was automatically updated to reflect the committed changes.