remove UnhandledErrorDialog
ClosedPublic

Authored by sitter on Jul 11 2019, 10:05 AM.

Details

Summary

the dialog was actually broken through at least all of plasma5 :/

this is no longer necessary. it was used for when random unexpected HTML
would get returned. there is no longer unexpected html:

  • the api always returns json blobs
  • should the api crap out we'll get protocol errors (HTTP 500 or some such) which is also forced into a serialized form and raised as a ProtocolException to be handled like errors from the API directly

we always get one "standardized" error message and never an
extended html to display.

Test Plan

builds

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 11 2019, 10:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2019, 10:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jul 11 2019, 10:05 AM
apol accepted this revision.Jul 11 2019, 11:52 AM
This revision is now accepted and ready to land.Jul 11 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.