Bug fix https://bugs.kde.org/show_bug.cgi?id=143306
Coordinates showing in floating message in format: X: x px, Y: y px.
X, Y means position of Left Top vertix.
Also there are two spin bars, which you can use for setting image position by keyboard (not only arrows)
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Hi, @tantsevov!
Codewise, there are two minor issues, but they are not very serious. People can start testing this patch.
We need painters to check what they think about it. I have only two UIX related comments:
- The floating box looks ugly and eats the space of the working area of a user.
- The text in a message "%1 px, %2 px (%3 px, %4 px)" can be made more understandable somehow (we need to ask @timotheegiet, @Deevad and @scottpetrovic about how to do that)
| plugins/tools/basictools/kis_tool_move.cc | ||
|---|---|---|
| 291 | Better use a projection(), because that is what the user sees when the layer is moves. totalBounds |= node->projection()->nonDefaultPixelArea(); Try to add a transparency mask to a layer and test :) | |
| 332 | There is a simple idiom for things like that in Qt: totalTopLeft = QPoint(); | |
Comment Actions
Found an inconvenient thing
| plugins/tools/basictools/kis_tool_move.cc | ||
|---|---|---|
| 312 | Btw, here I would expect m_accumulatedOffset.x()/y() added, to see the total offset of multiple drags. Right now you show an offset of a single drag only. It is hardly interesting for a user. | |
Comment Actions
I tested the last patch, I don't think it looks ugly (it looks the same as other notifications like zoom..), but it would be much better with labels for each value to directly know what they are.
Something like:
New position
X: value ; Y: value
Move distance:
X: value ; Y: value
Comment Actions
Added ability to switch method of showing coordinates in status bar. You can switch it by "choice" in code.
Comment Actions
Also, I think an option to enable/disable this notification in the move tool options could be useful.
Comment Actions
I tested the last patch with coordinates in status bar, replacing all status bar content.
It seems to work good, but:
-it won't be visible in canvas only mode
-it goes away too fast maybe
Also, regardless of this, the notification should also be triggered when moving with arrow keys
(which allows to move precisely, when move tool is selected...)
Comment Actions
Now I kept only floating message. Coordinates showing when you move something with your computer mouse or with keys. This ability is switchable. You can toggle it on/off in Tool Option or by shortcut. Now it's Ctrl+Alt+Shift+C, but I can change it if someone tell me the right combination.
P. S. Changed format of message, as @timotheegiet advised. Now it has this format:
New position
X: value ; Y: value
Move distance:
X: value ; Y: value
Comment Actions
Update! =) Changed message format. Now it shows only position coordinates in format: X: x px, Y: y px. Also added two spin boxes for this cordinates, like in Transform Tool.
| plugins/tools/basictools/kis_tool_move.cc | ||
|---|---|---|
| 474 | This function seems to be unused :) | |
Comment Actions
This revision looks very good, the only missing piece is a mouse-over message with the shortcut info on "Show coordinates on canvas" and its checkbox.
Comment Actions
Fixed bug with updating coordinates after switching nodes with active Move Tool. Now it updates correct (I hope).
Comment Actions
The patch works perfectly, thank you @tantsevov! I will push it as soon as the kde git will become up again :)