Differential D22348

lspclient: Use the label when insertText or sortText is missing
ClosedPublic
Actions

Authored by ogoffart on Jul 9 2019, 5:25 PM.

Details

Reviewers
cullmann
mnauwelaerts
Commits
R40:e554505e0c01: lspclient: Use the label when insertText or sortText is missing
Summary

The spec for these fields say: "When falsy the label is used."

Test Plan

Tested with the Rust LSP, where the insertText field is usually empty

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ogoffart created this revision.Jul 9 2019, 5:25 PM
Restricted Application added a project: Kate. · View Herald TranscriptJul 9 2019, 5:25 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
ogoffart requested review of this revision.Jul 9 2019, 5:25 PM
ogoffart added a reviewer: cullmann.
cullmann added a comment.Jul 10 2019, 7:03 AM

We pinged the lspclient author to look at these requests (and create an account here, we didn't find the right one to add ;=)

mnauwelaerts accepted this revision.Jul 10 2019, 4:58 PM
mnauwelaerts added a reviewer: mnauwelaerts.
mnauwelaerts added a subscriber: mnauwelaerts.

Oops, missed that part, but by the spec indeed.

This revision is now accepted and ready to land.Jul 10 2019, 4:58 PM
Closed by commit R40:e554505e0c01: lspclient: Use the label when insertText or sortText is missing (authored by ogoffart). · Explain WhyJul 11 2019, 5:26 AM
This revision was automatically updated to reflect the committed changes.
cullmann reopened this revision.Jul 21 2019, 11:47 AM

Hi, quick licensing question: We would like to re-license the lsp plugin as MIT, to have the chance to later out-source parts to a more commonly used library, would that license be ok for your two patches?

This revision is now accepted and ready to land.Jul 21 2019, 11:47 AM
ogoffart added a comment.Jul 21 2019, 6:37 PM

Sure, no problems.

cullmann closed this revision.Jul 21 2019, 6:44 PM

Thanks!

Revision Contents
Changeset List

Diff 61560

View Options

addons/lspclient/lspclientserver.cpp

Loading...