Should we install bluezqt_dbustypes.h?
Needs ReviewPublic

Authored by joselema on Jul 9 2019, 5:10 PM.

Details

Summary

Hi,

while doing packaging work on bluez-qt for Kubuntu, we detected the following situation:

Since the addition of this code:
https://cgit.kde.org/bluez-qt.git/commit/?id=1a5660ab1547236c7bc0f883bbbb039889489a22
https://phabricator.kde.org/D21584

there's a number of installed c++ headers which have the following include:

#include "bluezqt_dbustypes.h"

however bluezqt_dbustypes.h is NOT installed along with the headers which are suposed need it

An example of this is src/gattapplication.h:
https://cgit.kde.org/bluez-qt.git/diff/src/gattapplication.h?id=1a5660ab1547236c7bc0f883bbbb039889489a22

So, even while I don't understand the code involved, I have the impression that bluezqt_dbustypes.h must be installed along with the other headers. If that's the case I can commit and push the patch proposed.

Thank you for your time.

Test Plan

We detected this thing because we have a test in our packaging which checks if the installed headers can be built and fails if they are missing bits. I ran the test in question with the attached patch and it doesn't fail.

Diff Detail

Repository
R269 BluezQt
Lint
Lint Skipped
Unit
Unit Tests Skipped
joselema created this revision.Jul 9 2019, 5:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 9 2019, 5:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
joselema requested review of this revision.Jul 9 2019, 5:10 PM

We detected this thing because we have a test in our packaging which checks if the installed headers can be built and fails if they are missing bits. I ran the test in question with the attached patch and it doesn't fail.

The KDE CI has the acc test as well:

https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/28/console

13:33:41 Checking header(s) 5.60.0 ...
13:33:44 ERROR: some errors occurred when compiling headers
13:33:44 ERROR: see log for details:
13:33:44 /home/jenkins/workspace/Frameworks/bluez-qt/kf5-qt5 SUSEQt5.12/logs/KF5BluezQt/5.60.0/log.txt
13:33:44
13:33:44 ERROR: can't compile header(s)
13:33:44 ERROR:root:abi-compliance-checker exited with 5

Bizarrely though, failing that test doesn't even make the KDE CI go yellow/fail the jobs tests.