Unify simple and normal playlist entry
ClosedPublic
Actions

Authored by astippich on Jul 9 2019, 5:03 PM.

Details

Reviewers

mgallien
ngraham

Commits

R255:e28df06a742d: Unify simple and normal playlist entry

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.Jul 9 2019, 5:03 PM

astippich created this revision.

Very nice.

This revision is now accepted and ready to land.Jul 9 2019, 6:35 PM

Actually sorry, just found a UI regression.

Before:

With your patch:

Long song text only needs to be elided when the inline controls are visible.

This revision now requires changes to proceed.Jul 9 2019, 6:51 PM

This revision is now accepted and ready to land.Jul 9 2019, 7:09 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/CMakeLists.txt (1 line)
M		src/qml/PlayListEntry.qml (171 lines)
D	M	src/qml/SimplePlayListEntry.qml (306 lines)
M		src/qml/SimplePlayListView.qml (58 lines)
M		src/resources.qrc (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61430	f46c10e		Jul 9 2019, 5:03 PM	★	★
Diff 2	61444	f46c10e	- fix text elide after hovering items	Jul 9 2019, 6:58 PM	★	★
Diff 3	61453	a1a69dc	R255:e28df06a742d6d66616758e729d9f97187f3877e	Jul 9 2019, 8:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ddf248f5d4a7	cd0fcf440bf6	04bee9a164e9	Alexander Stippich	fix text elide after hovering items	Jul 9 2019, 6:57 PM
04bee9a164e9	a5896ebc430f	f46c10e4fc4e	Alexander Stippich	Unify simple and normal playlist entry (Show More…)	Jul 9 2019, 5:01 PM