Differential D22341

[mobile/wifi] Port to SimpleKCM
ClosedPublic
Actions

Authored by nicolasfella on Jul 9 2019, 2:16 PM.

Details

Reviewers
mart
jgrulich
Group Reviewers
Plasma
Commits
R116:b1e218b92a3b: [mobile/wifi] Port to SimpleKCM
Summary

The plasma-settings app assumes all KCMs to be based on the types from KDeclarative

Test Plan

Runs in plasma-settings

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 9 2019, 2:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 9 2019, 2:16 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 9 2019, 2:16 PM
mart accepted this revision.Jul 9 2019, 2:24 PM

LGTM,
still needs approval by Jan

jgrulich accepted this revision.Jul 9 2019, 4:38 PM
This revision is now accepted and ready to land.Jul 9 2019, 4:38 PM
Closed by commit R116:b1e218b92a3b: [mobile/wifi] Port to SimpleKCM (authored by nicolasfella). · Explain WhyJul 10 2019, 7:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61483

View Options

mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml

Loading...
View Options

mobile/wifi/package/contents/ui/NetworkListView.qml

Loading...
View Options

mobile/wifi/package/contents/ui/NetworkSettings.qml

Loading...
View Options

mobile/wifi/package/contents/ui/main.qml

Loading...