Differential D22338

Save blueprint config in cache manifest, if config differs, don't restore from cache
AbandonedPublic
Actions

Authored by vonreth on Jul 9 2019, 9:36 AM.

Details

Reviewers
bcooksley

Diff Detail

Repository
R138 Craft
Branch
binary_cache_config
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13738
Build 13756: arc lint + arc unit
vonreth requested review of this revision.Jul 9 2019, 9:36 AM
vonreth created this revision.
vonreth updated this revision to Diff 61398.Jul 9 2019, 9:40 AM

Remove debug oupu

bcooksley accepted this revision.Jul 9 2019, 7:22 PM

This looks okay to me.

For commit purposes I'd suggest splitting out the code style / variable name changes to a separate commit from the config hashing bits though.

This revision is now accepted and ready to land.Jul 9 2019, 7:22 PM
vonreth abandoned this revision.Jul 20 2019, 10:05 AM

was merged

Revision Contents
Changeset List

Diff 61398

View Options

bin/Package/PackageBase.py

Loading...
View Options

bin/Packager/PackagerBase.py

Loading...
View Options

bin/Utils/CraftManifest.py

Loading...
View Options

bin/options.py

Loading...