Differential D22317

Fix type names casing
ClosedPublic
Actions

Authored by apol on Jul 8 2019, 12:28 AM.

Details

Reviewers
vkrause
Group Reviewers
Frameworks
Android
Commits
R240:70ae7cff8bc7: Fix type names casing
Summary

It's supposed to be uppercase, cmake was warning about it.

Test Plan

Now it builds as well, but cmake doesn't complain.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 8 2019, 12:28 AM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJul 8 2019, 12:28 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 8 2019, 12:28 AM
vkrause accepted this revision.Jul 8 2019, 6:50 AM
This revision is now accepted and ready to land.Jul 8 2019, 6:50 AM
Closed by commit R240:70ae7cff8bc7: Fix type names casing (authored by apol). · Explain WhyJul 8 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.
vatra added a subscriber: vatra.Jul 9 2019, 5:48 AM

Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake

apol added a comment.Jul 9 2019, 3:07 PM
In D22317#492656, @vatra wrote:

Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake

We could consider it. Our toolchain predates android's cmake adoption though.

Also we'd still need to have some gluing bits to include the androiddeployqt generation bits which actually is mostly what we do in our toolchain file, the rest is quite simple.

Revision Contents
Changeset List

PathPackages
Mtoolchain/Android.cmake (4 lines)

Diff 61334

View Options

toolchain/Android.cmake

Loading...