Make the context view part of the main content
ClosedPublic
Actions

Authored by astippich on Jul 7 2019, 2:51 PM.

Details

Reviewers

mgallien
ngraham

Commits

R255:79131c04869b: Make the context view part of the main content

Summary

Make the context/now playing view behave like every other tab.
Add an icon to the header.

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.Jul 7 2019, 2:51 PM

astippich created this revision.

Harbormaster completed remote builds in B13679: Diff 61281.Jul 7 2019, 2:51 PM

New look:

IMHO this looks and behaves more consistently if the now playing view is treated the same as every other view.
As a bonus, this also gives a nice code cleanup in the content view

always enable playlist toggle action

Harbormaster completed remote builds in B13680: Diff 61282.Jul 7 2019, 2:58 PM

+1, this makes perfect sense IMO. Code looks good!

This revision is now accepted and ready to land.Jul 7 2019, 6:41 PM

astippich retitled this revision from [RFC] Make the context view part of the main content to Make the context view part of the main content.Jul 8 2019, 5:41 PM

Closed by commit R255:79131c04869b: Make the context view part of the main content (authored by astippich). · Explain WhyJul 8 2019, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/viewmanagertest.cpp (19 lines)
M			src/models/viewsmodel.cpp (8 lines)
M			src/qml/ApplicationMenu.qml (2 lines)
M			src/qml/BaseTheme.qml (1 line)
M			src/qml/ContentView.qml (112 lines)
M			src/qml/ContextView.qml (19 lines)
M			src/viewmanager.h (17 lines)
M			src/viewmanager.cpp (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61281	64709c7		Jul 7 2019, 2:51 PM	★	★
Diff 2	61282	64709c7	- always enable playlist toggle action	Jul 7 2019, 2:58 PM	★	★
Diff 3	61361	64709c7	R255:79131c04869b2351f7816f0dd7528854694a624d	Jul 8 2019, 5:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8fd0c3532a86	d8173dd0eea2	5bc1896fb351	Alexander Stippich	always enable playlist toggle action	Jul 7 2019, 2:58 PM
5bc1896fb351	53bbffe451e6	de2b6e126741	Alexander Stippich	[RFC] Make the context view part of the main content (Show More…)	Jul 4 2019, 8:24 PM
de2b6e126741	7da1ef235b01	64709c703642	Alexander Stippich	make the context view part of the main content	Jul 4 2019, 7:16 PM