Differential D22305

Fix MIME type not determined for small files
ClosedPublic
Actions

Authored by tommo on Jul 7 2019, 10:22 AM.

Details

Reviewers
ngraham
Group Reviewers
Gwenview
Commits
R260:d89a2e917c1b: Fix MIME type not determined for small files
Summary

Previously, LoadingDocumentImplPrivate::determineKind() was never called for files < HEADER_SIZE when transferred via KIO, which prevented to load them correctly.

Test Plan

Modify LoadingDocumentImpl::init() to make it always load files via KIO. Compile and execute documenttest. Before the fix it will be stuck in an endless loop. Afterwards it completes normally.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tommo requested review of this revision.Jul 7 2019, 10:22 AM
tommo created this revision.
tommo edited the summary of this revision. (Show Details)Jul 7 2019, 10:25 AM
ngraham accepted this revision.Jul 7 2019, 12:08 PM
ngraham added a subscriber: ngraham.

Thanks!

This revision is now accepted and ready to land.Jul 7 2019, 12:08 PM
Closed by commit R260:d89a2e917c1b: Fix MIME type not determined for small files (authored by tommo, committed by ngraham). · Explain WhyJul 7 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61272

View Options

lib/document/loadingdocumentimpl.cpp

Loading...