Add id="current-color-scheme" to collapse-all icons
ClosedPublic
Actions

Authored by nhiga on Jul 6 2019, 11:36 AM.

Details

Reviewers

davidhurka
ndavis

Group Reviewers

VDG

Commits

R266:8ec6b1ba5670: Add id="current-color-scheme" to collapse-all icons

Summary

collapse-all icons have no id="current-color-scheme" attribute in the <style> element, so they do not respect the foreground color and these icons are hardly visible in dark color themes.

Special thanks: David Hurka, who reported the bug and suggested the change

BUG: 409546

Usage in Okular, Before:

After:

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Summary will be filled in later.

Related: D19575, Bug 409546

@davidhurka

Would you please try this diff and see if it resolves the bug?

Yes, problem solved. The icon is now visible with a dark color theme.

Did not check anything else, someone with more knowledge about icons should do that.

This revision is now accepted and ready to land.Jul 6 2019, 11:55 AM

nhiga edited the summary of this revision. (Show Details)Jul 6 2019, 12:14 PM

(Added screenshots)

LGTM

Closed by commit R266:8ec6b1ba5670: Add id="current-color-scheme" to collapse-all icons (authored by Natsumi Higa <r0106.nhiga.kde@protonmail.com>, committed by ngraham). · Explain WhyJul 7 2019, 12:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/actions/16/collapse-all.svg (11 lines)
M			icons-dark/actions/22/collapse-all.svg (11 lines)
M			icons-dark/actions/24/collapse-all.svg (11 lines)
M			icons-dark/actions/32/collapse-all.svg (11 lines)
M			icons/actions/16/collapse-all.svg (11 lines)
M			icons/actions/22/collapse-all.svg (11 lines)
M			icons/actions/24/collapse-all.svg (11 lines)
M			icons/actions/32/collapse-all.svg (11 lines)