Fix display sometimes randomly scrolling down

Authored by sandsmark on Jul 5 2019, 4:38 PM.


Group Reviewers

Something in Qt has changed, so e. g. Super_L isn't passed as a modifier
anymore, so there's a regression from what
eea5ecfc5ed93515afaae5b9b938154eeaaf0ba8 fixed.

This is especially annoying e. g. for people using i3, where just
switching focus away with the keyboard will lead to Konsole scrolling
back to the bottom.

Test Plan

Scroll up, press e. g. the left Windows key, and change focus away and back to Konsole.

Diff Detail

R319 Konsole
Lint Skipped
Unit Tests Skipped
sandsmark created this revision.Jul 5 2019, 4:38 PM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 5 2019, 4:38 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
sandsmark requested review of this revision.Jul 5 2019, 4:38 PM
mglb accepted this revision.Jul 6 2019, 3:31 PM

Bug confirmed with Qt 5.13.
The patch fixes it.

This revision is now accepted and ready to land.Jul 6 2019, 3:31 PM
ngraham added a subscriber: ngraham.Jul 7 2019, 2:01 AM

@hindenburg or @tcanabrava, I know this isn't on gitlab, but can we evaluate this here? IMO it's terribly confusing for people to have two places to submit patches, with only one being newly blessed as the correct one, and no documentation about it.

Created a merge request here, I think I did it right:

hindenburg closed this revision.Jul 7 2019, 10:46 PM

Thanks, already merged - we can still use phabricator for simple request if people have it already setup.