Update stopwatch granularity on change in settings
ClosedPublic

Authored by gshah on Jul 5 2019, 2:51 PM.

Details

Summary

Bug: 349861

[This is my first commit to KDE, so bear with me if something is wrong. Thank you.]

Steps to Reproduce:

  1. Open Kronometer
  2. Show only tenths of seconds from the settings
  3. Start the stopwatch
  4. Show also the hundredths of second from the settings

Actual Results:
The hundredth digit is stuck to the previous digit.

Expected Results:
The hundredth digit should be updated every 1/100 of second.

The same happens with milliseconds.

Test Plan

This is a simple basic bug so test plan not required.

Diff Detail

Repository
R136 Kronometer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gshah requested review of this revision.Jul 5 2019, 2:51 PM
gshah created this revision.
elvisangelaccio accepted this revision.Jul 7 2019, 8:02 PM

Thanks for the patch!

Please provide an email address so that we can push the commit on your behalf.

This revision is now accepted and ready to land.Jul 7 2019, 8:02 PM
gshah added a comment.Jul 8 2019, 4:38 AM

This is the email address.

gauravshah.89@gmail.com

Thanks.

This revision was automatically updated to reflect the committed changes.
shubham added a subscriber: shubham.Jul 8 2019, 5:23 AM

There you go, congratulations on your first patch!!