Fix "QFSFileEngine::open: No file name specified" warning
ClosedPublic
Actions

Authored by dfaure on Jul 4 2019, 7:11 PM.

Details

Reviewers

mardelle

Commits

Summary

The transition repository returns an empty string in
assetPreferredListPath(), which QFile doesn't really like.

Test Plan

Builds

Repository

R158 Kdenlive

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Jul 4 2019, 7:11 PM

dfaure created this revision.

pino added inline comments.

src/assets/abstractassetsrepository.ipp
45	unneeded change
48	ditto

src/assets/abstractassetsrepository.ipp
45	Unrelated, possibly, but not unneeded. Clearly this class was abstracted from what was originally only about effects, while now it's "abstract" and used for both effects and transitions, under the name "assets". So reading "effects" here was confusing.
48	ditto :-)

Thanks, can you push it ? (we are using gitlab)

This revision is now accepted and ready to land.Jul 5 2019, 5:47 AM

This revision was automatically updated to reflect the committed changes.

gitlab? Ah, that's why I couldn't push to git.kde.org!

Done, pushed to invent.kde.org

We need to update kdesrc-build / kde-build-metadata so it fetches kdenlive from invent.kde.org

			Path	Packages
M			src/assets/abstractassetsrepository.ipp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61169	39137f4		Jul 4 2019, 7:11 PM	★	★
Diff 2	61198	b8d7393	R158:c1f06eaa5811b8d564db445287c9fb509f6f2db9	Jul 5 2019, 8:32 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
3ee9cbcfada3	b141a50a9fca	39137f43e1c9	David Faure	Fix "QFSFileEngine::open: No file name specified" warning (Show More…)	Jul 4 2019, 7:07 PM