ContainmentAction: Fix loading from KPlugin
ClosedPublic

Authored by apol on Jul 4 2019, 1:32 PM.

Details

Summary

At the moment it was enabled in the PluginLoader but we were not using it anywhere.

Test Plan

See patch in plasma-workspace.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 4 2019, 1:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 4 2019, 1:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 4 2019, 1:32 PM
mart accepted this revision.Jul 4 2019, 1:36 PM
This revision is now accepted and ready to land.Jul 4 2019, 1:36 PM
This revision was automatically updated to reflect the committed changes.

Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look.

Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look.

Ah, my had. This is the build variant as part of the Plasma products, not the KF products. And there the kcoreaddons only is built as part of the Plasma Deps (so once a week or manual trigger), thus the respective change to kcoreaddons was not yet avail. Triggered a rebuild of the deps now, so we can get back to Green/Blue.

P-F build results look fine on the normal KF builds.

FTR now that all dep builds are updated, the plasma-frameworks part of the Plasma product also all passed, so all as it should.