Status: Needs Review
- Added multiple datasets to Calendar and find the day activity.
- Created a generic algorithm to generate template questions as per the parameters it is provided
Status: Needs Review
Apply the diff on multiple_dataset branch or pull the changes from the branch gsoc_akshaychd_calendar_multiple_datasets
Shouldn't Math.floor((maxMonth - minMonth)) be Math.floor(maxMonth - minMonth + 1)?
Let's say minMonth is 3 and maxMonth is 5. I should get any random among 0, 1, 2 so that minMonth + Math.floor(Math.random() * Math.floor((maxMonth - minMonth))) can be anything between 3, 4, 5.
But, Math.floor(Math.random() * Math.floor((maxMonth - minMonth))) limits the values among 0, 1 (as minMonth - maxMonth = 2 in our case). So you should probably do maxMonth - minMonth + 1?
Same comment about choosing random value as above.
I tested the patch on multiple_dataset branch, and noticed several issues.
In Find the date:
-some questions, the answer can not be entered (it is out of the accessible range)
Reproduced with first dataset at level 3 and 5 (see screenshots 1, 2 and 3)
-a question was twice the same, happened with second dataset at first level.
-some question did not accept the correct answer (see on screenshot 4 and 5, the answer to the question is correct and still the answer is not accepted).
In Calendar activity:
-At level 3, the questions mention the month and year which is not visible. Better do like in level 4 and say "of given month" instead.
Another note: the datasets have difficulty stars 1 and 3, while the activities initial difficulty level were 1 and 3 red stars (meaning level 4 and 6 respectively)
It would be better to adapt the stars of the datasets accordingly.
@dekumar it seems you didn't created the branch from Akshay's one, so the diff contains a lot of files that shouldn't be there.
The diff should only contain files from calendar and find_the_day activities.
To do so, checkout the good branch, and do a git checkout -b "your_branch" and update the diff here please