Thumbnails sidebar always open when okular starts
Needs ReviewPublic

Authored by mayankchoudhary on Jul 4 2019, 10:06 AM.

Details

Reviewers
aacid
ngraham
Group Reviewers
Okular
Summary

Every time Okular starts, one of the items of the Sidebar is open (usually the Thumbnails panel).There is no way to disable it globally. It would be convenient to the users to automatically save the state of the panel upon exit and restore it when the Okular is opened again.
FEATURE: 344599

Test Plan
  1. Open a PDF with Okular
  2. You will find that one of the items of the side navigation panel is open
  3. Click on the item icon of the navigation panel to minimize item's panel
  4. Close Okular
  5. Reopen Okular with same or different file as in step 1
  6. One of the items of the side navigation panel is again open
  7. But after applying this patch, the side navigation panel should be remain collapsed in step 6 with none of the item is selected

Diff Detail

Repository
R223 Okular
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13591
Build 13609: arc lint + arc unit
Restricted Application added a project: Okular. · View Herald TranscriptJul 4 2019, 10:06 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
mayankchoudhary requested review of this revision.Jul 4 2019, 10:06 AM

Should i write autotests ?

When I am trying to write autotests the pointer moves outside of the okular window. I tried

QTest::mouseMove()

&

QPoint()

methods.

aacid added a comment.Jul 4 2019, 5:05 PM

Please use invent.kde.org for new Merge requests agains okular.

And yes you need to write tests.

aacid added a comment.Aug 8 2019, 9:12 PM

Why do you want to move the mouse?

mayankchoudhary added a comment.EditedAug 9 2019, 5:13 PM

I want to use the mouse to click on a sidebar item.

aacid added a comment.Aug 9 2019, 11:43 PM

Ok, let's see the code you have and tell us where it fails and we'll try to help :)