Differential D22257

performance, Qt API
ClosedPublic
Actions

Authored by apol on Jul 3 2019, 11:48 PM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Frameworks
Commits
R290:8e9fea2bc0bf: performance, Qt API
Summary

Use proper appending API
Don't look-up twice

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 3 2019, 11:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 3 2019, 11:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 3 2019, 11:48 PM
davidedmundson accepted this revision.Jul 4 2019, 9:56 AM
This revision is now accepted and ready to land.Jul 4 2019, 9:56 AM
mart accepted this revision.Jul 4 2019, 9:59 AM
bcooksley added a subscriber: bcooksley.Jul 4 2019, 10:12 AM

This change fails to build from source once committed.
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/35/changes#detail0

Please correct this urgently - at this very moment the CI system is proceeding through it's initial build run for just about everything on Qt 5.12 (with the dropping of Qt 5.10) and that will fail (and leave everyone apart from Plasma with no CI) if this isn't addressed quickly.

Closed by commit R290:8e9fea2bc0bf: performance, Qt API (authored by apol). · Explain WhyJul 4 2019, 10:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61121

View Options

src/kpackage/package.cpp

Loading...
View Options

src/kpackage/packageloader.cpp

Loading...