AbstractClient applies maximize rules by running
maximize(maximizeMode());
but because window rules are checked only in changeMaximize
implementation, the if statement prevents us from applying maximize
rules (m and maximizeMode() are equal).
Details
Details
- Reviewers
romangg - Group Reviewers
KWin - Commits
- R108:3e1b61664224: Merge branch 'Plasma/5.16'
R108:0a9c25476951: Fix maximize Apply Now rule
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- foo
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13690 Build 13708: arc lint + arc unit
Comment Actions
That we need this conditional removed indicates that the structure is wrong how we check for the maximize rule. And looking at the code we have methods maximize, setMaximize and changeMaximize in quick succession. I'm pretty sure we could remove at least one of these three.
Nevertheless let's get this in as a quick fix.
Comment Actions
maximize is just a wrapper around setMaximize, another name for changeMaximize is doMaximize (a better one).
Comment Actions
Argh, it's sort of embarassing but I forgot to include one vital change
in ShellClient::changeMaximize.
We need to move the guard from AbstractClient::maximize to ShellClient::
changeMaximize, otherwise test suite will be red-ish.
Client::changeMaximize already contains that guard.