AbstractClient applies maximize rules by running
maximize(maximizeMode());
but because window rules are checked only in changeMaximize
implementation, the if statement prevents us from applying maximize
rules (m and maximizeMode() are equal).
romangg |
KWin |
AbstractClient applies maximize rules by running
maximize(maximizeMode());
but because window rules are checked only in changeMaximize
implementation, the if statement prevents us from applying maximize
rules (m and maximizeMode() are equal).
Lint OK |
No Unit Test Coverage |
Buildable 13582 | |
Build 13600: arc lint + arc unit |
That we need this conditional removed indicates that the structure is wrong how we check for the maximize rule. And looking at the code we have methods maximize, setMaximize and changeMaximize in quick succession. I'm pretty sure we could remove at least one of these three.
Nevertheless let's get this in as a quick fix.
maximize is just a wrapper around setMaximize, another name for changeMaximize is doMaximize (a better one).
Argh, it's sort of embarassing but I forgot to include one vital change
in ShellClient::changeMaximize.
We need to move the guard from AbstractClient::maximize to ShellClient::
changeMaximize, otherwise test suite will be red-ish.
Client::changeMaximize already contains that guard.