Turn Attachment into an implicitly shared value type
ClosedPublic

Authored by vkrause on Jul 3 2019, 5:11 PM.

Details

Summary

Avoids the extra allocation, and makes this easier to directly expose to
QML/Grantlee/etc.

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jul 3 2019, 5:11 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 3 2019, 5:11 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jul 3 2019, 5:11 PM
dvratil accepted this revision.Jul 3 2019, 7:21 PM
dvratil added a subscriber: dvratil.

Looks good, just make the default ctor explicit before committing, please.

src/attachment.h
71

explicit

This revision is now accepted and ready to land.Jul 3 2019, 7:21 PM
This revision was automatically updated to reflect the committed changes.