diff --git a/src/backtraceratingwidget.h b/src/backtraceratingwidget.h --- a/src/backtraceratingwidget.h +++ b/src/backtraceratingwidget.h @@ -47,10 +47,7 @@ BacktraceGenerator::State m_state; - bool m_star1; - bool m_star2; - bool m_star3; - + int m_numStars; QPixmap m_errorPixmap; QPixmap m_starPixmap; diff --git a/src/backtraceratingwidget.cpp b/src/backtraceratingwidget.cpp --- a/src/backtraceratingwidget.cpp +++ b/src/backtraceratingwidget.cpp @@ -24,10 +24,7 @@ BacktraceRatingWidget::BacktraceRatingWidget(QWidget * parent) : QWidget(parent), - m_state(BacktraceGenerator::NotLoaded), - m_star1(false), - m_star2(false), - m_star3(false) + m_state(BacktraceGenerator::NotLoaded) { setMinimumSize(105, 24); @@ -38,55 +35,39 @@ void BacktraceRatingWidget::setUsefulness(BacktraceParser::Usefulness usefulness) { - switch (usefulness) { - case BacktraceParser::ReallyUseful: { - m_star1 = true; - m_star2 = true; - m_star3 = true; + switch(usefulness) { + case BacktraceParser::ReallyUseful: + m_numStars = 3; break; - } - case BacktraceParser::MayBeUseful: { - m_star1 = true; - m_star2 = true; - m_star3 = false; + case BacktraceParser::MayBeUseful: + m_numStars = 2; break; - } - case BacktraceParser::ProbablyUseless: { - m_star1 = true; - m_star2 = false; - m_star3 = false; + case BacktraceParser::ProbablyUseless: + m_numStars = 1; break; - } - case BacktraceParser::Useless: - case BacktraceParser::InvalidUsefulness: { - m_star1 = false; - m_star2 = false; - m_star3 = false; + case BacktraceParser::Useless: + case BacktraceParser::InvalidUsefulness: + m_numStars = 0; break; } - } - update(); } void BacktraceRatingWidget::paintEvent(QPaintEvent * event) { Q_UNUSED(event); QPainter p(this); - - p.drawPixmap(QPoint(30, 1) , m_star1 ? m_starPixmap : m_disabledStarPixmap); - p.drawPixmap(QPoint(55, 1) , m_star2 ? m_starPixmap : m_disabledStarPixmap); - p.drawPixmap(QPoint(80, 1) , m_star3 ? m_starPixmap : m_disabledStarPixmap); + p.drawPixmap(QPoint(30, 1) , m_numStars >= 1 ? m_starPixmap : m_disabledStarPixmap); + p.drawPixmap(QPoint(55, 1) , m_numStars >= 2 ? m_starPixmap : m_disabledStarPixmap); + p.drawPixmap(QPoint(80, 1) , m_numStars >= 3 ? m_starPixmap : m_disabledStarPixmap); switch (m_state) { case BacktraceGenerator::Failed: case BacktraceGenerator::FailedToStart: { p.drawPixmap(QPoint(0, 1) , m_errorPixmap); break; } - case BacktraceGenerator::Loading: - case BacktraceGenerator::Loaded: default: break; } diff --git a/src/backtracewidget.cpp b/src/backtracewidget.cpp --- a/src/backtracewidget.cpp +++ b/src/backtracewidget.cpp @@ -339,15 +339,13 @@ void BacktraceWidget::hilightExtraDetailsLabel(bool hilight) { - QString stylesheet; - if (hilight) { - stylesheet = QLatin1String("border-width: 2px; " - "border-style: solid; " - "border-color: red;"); - } else { - stylesheet = QLatin1String("border-width: 0px;"); - } - stylesheet += QLatin1String(extraDetailsLabelMargin); + const QString stylesheet = ((!hilight) + ? QLatin1String("border-width: 0px;") + : QLatin1String("border-width: 2px; " + "border-style: solid; " + "border-color: red;")) + + QLatin1String(extraDetailsLabelMargin); + ui.m_extraDetailsLabel->setStyleSheet(stylesheet); } @@ -396,9 +394,9 @@ missingDbgForFiles.insert(0, DrKonqi::crashedApplication()->executable().absoluteFilePath()); //HTML message - QString message = QStringLiteral(""); - message += i18n("The packages containing debug information for the following application and libraries are missing:"); - message += QStringLiteral("