Differential D22233

Code Simplification / Readability Changes
ClosedPublic
Actions

Authored by tcanabrava on Jul 3 2019, 9:22 AM.

Details

Reviewers

sitter

Commits

R871:6fd8a05b4da5: Code Simplification / Readability Changes

Summary

Small changes thru the codebase to improve readability.
One potential crash fixed, and an old file removed.

Test Plan

run ctest. same results as running with master.

Diff Detail

Repository

R871 DrKonqi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tcanabrava created this revision.Jul 3 2019, 9:22 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2019, 9:22 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

tcanabrava requested review of this revision.Jul 3 2019, 9:22 AM

Harbormaster completed remote builds in B13551: Diff 61054.Jul 3 2019, 9:22 AM

tcanabrava retitled this revision from Simplify algorithm to draw the stars. to Code Simplification / Readability Changes.Jul 3 2019, 9:24 AM

tcanabrava edited the test plan for this revision. (Show Details)

sitter added a subscriber: sitter.Jul 3 2019, 9:30 AM

sitter added inline comments.

src/backtraceratingwidget.cpp
61–63	Can we switch over m_usefullness instead? Using enums as integers gets me all worked up.

broulik added a subscriber: broulik.Jul 3 2019, 9:32 AM

broulik added inline comments.

src/backtraceratingwidget.h
50	`usefulness` with one L
src/debugger.cpp
91–93	I find early returns to be more readable. Maybe just remove the explicit `} else {` statement
src/drkonqi.cpp
84–85	+1

tcanabrava marked an inline comment as done.Jul 3 2019, 9:33 AM

tcanabrava added inline comments.

src/debugger.cpp
91–93	@broulik those changes where made to keep the rest of the file in sync (all of the other functions are using this style)

tcanabrava marked 2 inline comments as done.Jul 3 2019, 9:59 AM

Store the number of stars instead of the Enum

Harbormaster completed remote builds in B13552: Diff 61056.Jul 3 2019, 10:01 AM

I continue to want a switch on the usefulness. If another usefulness gets introduced only a switch will ensure that we get a compiler warning if that new value isn't handled.

Store the number of stars instead of the Enum
Check enums with switch

Harbormaster completed remote builds in B13561: Diff 61068.Jul 3 2019, 1:30 PM

sitter accepted this revision.Jul 3 2019, 1:31 PM

This revision is now accepted and ready to land.Jul 3 2019, 1:31 PM

Closed by commit R871:6fd8a05b4da5: Code Simplification / Readability Changes (authored by tcanabrava). · Explain WhyJul 3 2019, 1:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/backtraceratingwidget.h (5 lines)
M		src/backtraceratingwidget.cpp (47 lines)
M		src/backtracewidget.cpp (22 lines)
M		src/crashedapplication.cpp (13 lines)
M		src/debugger.cpp (51 lines)
M		src/drkonqi.h (1 line)
M		src/drkonqi.cpp (13 lines)
D	M	src/findconfigdatajob.h (70 lines)
D	M	src/findconfigdatajob.cpp (96 lines)
M		src/gdbhighlighter.cpp (2 lines)
M		src/main.cpp (1 line)
M		src/statusnotifier.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61054	23b9564		Jul 3 2019, 9:22 AM	★	★
Diff 2	61056	23b9564	- Store the number of stars instead of the Enum	Jul 3 2019, 10:01 AM	★	★
Diff 3	61068	d51962c	- Store the number of stars instead of the Enum	Jul 3 2019, 1:30 PM	★	★
Diff 4	61070	d51962c	R871:6fd8a05b4da5a915312075e26559f4261da69b4d	Jul 3 2019, 1:34 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
cccdbfc64ef8	dd2861914ae1	a3aaad697c8e	Tomaz Canabrava	Check enums with switch	Jul 3 2019, 1:31 PM
a3aaad697c8e	0029ec12d7a7	081bdede3af7	Tomaz Canabrava	Store the number of stars instead of the Enum	Jul 3 2019, 10:00 AM
081bdede3af7	1adba1e60e94	7b1c047dc1b3	Tomaz Canabrava	Simplify algorithm to draw the stars. (Show More…)	Jul 3 2019, 9:13 AM
7b1c047dc1b3	1bb040e7471d	3dce805784a3	Tomaz Canabrava	Const	Jul 3 2019, 9:12 AM
3dce805784a3	5b5419d3467f	85c003af37a0	Tomaz Canabrava	Remove unused class	Jul 3 2019, 9:02 AM
85c003af37a0	4a131b85b870	a3e7fa632d61	Tomaz Canabrava	Add missing QStringLiteral	Jul 3 2019, 8:58 AM
a3e7fa632d61	98b9037e4775	abf4f72e7610	Tomaz Canabrava	Remove broken call (Show More…)	Jul 3 2019, 8:47 AM
abf4f72e7610	de92099686f4	e99ebf69322e	Tomaz Canabrava	Use a static object to create the DrKonqui instance	Jul 3 2019, 8:43 AM
e99ebf69322e	39cff9ecccdd	407572059c30	Tomaz Canabrava	Use a initializer list to create the QHash	Jul 3 2019, 8:35 AM
407572059c30	c0ffb18163d9	45000bd21381	Tomaz Canabrava	Style: follow the rest of the file return style, using ?:	Jul 3 2019, 8:31 AM
45000bd21381	e6f0329ed994	f86016e02b22	Tomaz Canabrava	Const initialize the variable	Jul 3 2019, 8:15 AM
f86016e02b22	d9ad3ffd5503	b92b3e5aa73c	Tomaz Canabrava	Less changes to temporaries, create it in one go.	Jul 3 2019, 8:09 AM
b92b3e5aa73c	5b18d9156b62	09716c2043e4	Tomaz Canabrava	No need to list cases before a default if they Falltrougth	Jul 3 2019, 7:48 AM
09716c2043e4	b69247b91143	d51962c416aa	Tomaz Canabrava	Simplify algorithm to draw the stars.	Jul 3 2019, 7:33 AM