Differential D22229

Ignore Next/Previous call if CanGoNext/CanGoPrevious are false
ClosedPublic
Actions

Authored by broulik on Jul 3 2019, 7:21 AM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:0c1b8d57b0ea: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false
Summary

Spec says "If is false, attempting to call this method should have no effect."

Test Plan

No longer get an event in the content-script when calling Previous/Next if we can't go previous/next.
Still works if website sets a previoustrack or nexttrack callback

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 3 2019, 7:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2019, 7:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 3 2019, 7:21 AM
fvogt added a comment.Jul 3 2019, 7:29 AM

IMO this should be up to the content script, which seems to handle this properly already

This revision was not accepted when it landed; it landed in state Needs Review.Jul 5 2019, 11:58 AM
Closed by commit R856:0c1b8d57b0ea: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhost/mprisplugin.cpp (6 lines)

Diff 61212

View Options

host/mprisplugin.cpp

Loading...