Differential D22224

Motion control for domes added
ClosedPublic
Actions

Authored by wreissenberger on Jul 2 2019, 8:24 PM.

Details

Reviewers
mutlaqja
Commits
R321:7d6fbb121b20: Motion control for domes added
Summary

Controls added for dome motion:

  • absolute motion
  • relative motion
  • slaving
  • aborting motion

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Jul 2 2019, 8:24 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 2 2019, 8:24 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Jul 2 2019, 8:24 PM
mutlaqja requested changes to this revision.Jul 2 2019, 8:37 PM

Great work, the observatory module is shaping up nicely!

kstars/ekos/auxiliary/dome.h
76

Better use Q_PROPERTY as well like canAbsoluteMove and then expose over DBus in the org.kde.kstars.Ekos.Dome.xml file

kstars/ekos/observatory/observatory.cpp
425

Maybe QString::number(position, 'f', 2) ?

This revision now requires changes to proceed.Jul 2 2019, 8:37 PM
wreissenberger updated this revision to Diff 61039.Jul 2 2019, 9:11 PM
  • canRelativeMove added as D-Bus property
  • String formatting improved
wreissenberger marked 2 inline comments as done.Jul 2 2019, 9:12 PM

Hope it's like you meant.

mutlaqja accepted this revision.Jul 3 2019, 3:57 AM
This revision is now accepted and ready to land.Jul 3 2019, 3:57 AM
Closed by commit R321:7d6fbb121b20: Motion control for domes added (authored by wreissenberger, committed by mutlaqja). · Explain WhyJul 3 2019, 3:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61048

View Options

kstars/ekos/auxiliary/dome.h

Loading...
View Options

kstars/ekos/auxiliary/dome.cpp

Loading...
View Options

kstars/ekos/observatory/observatory.h

Loading...
View Options

kstars/ekos/observatory/observatory.cpp

Loading...
View Options

kstars/ekos/observatory/observatory.ui

Loading...
View Options

kstars/ekos/observatory/observatorydomemodel.h

Loading...
View Options

kstars/ekos/observatory/observatorydomemodel.cpp

Loading...
View Options

kstars/ekos/observatory/observatorymodel.cpp

Loading...
View Options

kstars/indi/indidome.h

Loading...
View Options

kstars/indi/indidome.cpp

Loading...
View Options

kstars/org.kde.kstars.Ekos.Dome.xml

Loading...