Large cleanup for all qml files regarding playlist.
Increase the button size in PlayListEntry so that it is easier
to click and set icon size.
Makes SimplePlayListEntry and PlayListEntry more similar.
Fixes display of multi-disc albums in the playlist view.
Adds accessibility to SimplePlayListEntry.
Remove warnings for SimplePlayListEntry due to missing data.
Details
Details
playlist has buttons with full delegate height,
multi-disc albums are showing correctly for the playlist,
no more warnings for SimplePlayListEntry
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This started as simple try to increase the button size in the playlist. This grow into a large cleanup and fixup once I realized how the SimplePlayList and the normal one are "linked" and found quite some old cruft and differences.
PlayListEntry and SimplePlayListEntry are very similar and should be merged, which I think this is a first step since it makes them even more similar.
Having two separate files already shows its disadvantage here: SimplePlayListEntry still had some dead code for handling the album art and no accessibility handling, while the PlayListEntry did not have the dead code but had accessibility handling.
The MediaPlayList also did not show multi-disc albums correctly.
Comment Actions
+1 for merging them; I noticed the same thing. Maybe that should even be done first or in this patch.
Comment Actions
I would very much prefer to merge the code as is and improve afterwards as it touches various place and would be a pain to rebase.
Comment Actions
I cannot review it now but it can go if you follow on with any issues that would be found. Sorry for my lack of time.