Differential D22198

Drop QOffscreenSurface guard
ClosedPublic
Actions

Authored by zzag on Jul 1 2019, 7:22 PM.

Details

Reviewers
romangg
Group Reviewers
KWin
Commits
R108:baabd20ef658: Drop QOffscreenSurface guard
Summary

Given that our QPA now creates native offscreen surfaces, we no longer
need the QOffscreenSurface guard introduced by 61956025f.

Diff Detail

Repository
R108 KWin
Branch
drop-guard
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13485
Build 13503: arc lint + arc unit
zzag created this revision.Jul 1 2019, 7:22 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 1 2019, 7:22 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 1 2019, 7:22 PM
romangg added a subscriber: romangg.Jul 1 2019, 7:26 PM

So for offscreen sufaces an InternalClient instance would not be created in the first place, right?

zzag added a comment.Jul 1 2019, 7:27 PM
In D22198#489225, @romangg wrote:

So for offscreen sufaces an InternalClient instance would not be created in the first place, right?

Yes, that's right.

romangg accepted this revision.Jul 1 2019, 7:28 PM
This revision is now accepted and ready to land.Jul 1 2019, 7:28 PM
Closed by commit R108:baabd20ef658: Drop QOffscreenSurface guard (authored by zzag). · Explain WhyJul 1 2019, 7:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minternal_client.cpp (16 lines)

Diff 60956

View Options

internal_client.cpp

Loading...