Effects in effects folder are final so we can mark them accordingly
just for convenience.
Details
- Reviewers
- None
- Group Reviewers
KWin
Compiles.
Diff Detail
- Repository
- R108 KWin
- Branch
- mark-effects-as-final
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 13477 Build 13495: arc lint + arc unit
It's harmless, so I don't exactly object, but I don't really understand what problem you're taking time to solve.
You can't subclass an effect by accident.
You can't subclass an effect by accident.
From technical point of view you're absolutely right, there's no point for it. On the other side marking these classes as final explicitly, improves readability of the code a bit (imho; that's perhaps subjective matter).
For readability sometimes code can also be too verbose. It's pretty clear that these effects normally won't get sub classed again. Or in which cases do you think a reader could assume otherwise?
You can't subclass an effect by accident.
There's an exception to this though - third party binary effects. They can't be final iirc.
Given that I'm not insisting on this change and it got slight resistance, I'll abandon the patch.