Add option to enable volume feedback
ClosedPublic

Authored by drosca on Jul 19 2016, 11:35 AM.

Details

Summary

Play "pop" sound when changing volume
BUG: 365197

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 5299.Jul 19 2016, 11:35 AM
drosca retitled this revision from to Add option to enable volume feedback.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 19 2016, 11:35 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.Jul 28 2016, 10:37 AM

Can we expect canberra to be available everywhere PA is?

It seems that it's just playing a short ticking sound, perhaps we can avoid the dependency easily?

Is the feedback only played when there is no other source playing?
If not, it should be done like that. If you already have something playing, it's just annoying to play an additional sound, and does not provide any additional info because you notice how loud whatever is playing plays.

Can we expect canberra to be available everywhere PA is?

KF5 kmix has it as non-optional dependency too, so I think that should not be issue.

Is the feedback only played when there is no other source playing?

It's played even if there is something playing. It uses the notification sounds event type, so if the user has it muted there will be no volume feedback sound even when enabled.
Also it is not trivial to detect if there is nothing playing, user may have for example some app that sets very low volume for its stream, or even there may be stream that is playing silence.

sebas added a comment.Jul 28 2016, 1:29 PM

Is the feedback only played when there is no other source playing?
If not, it should be done like that. If you already have something playing, it's just annoying to play an additional sound, and does not provide any additional info because you notice how loud whatever is playing plays.

I don't think it's technically feasible to detect if something else is playing. In general, I agree, but once you look closer, it's really complicated, too complicated, in fact.

sebas accepted this revision.Jul 28 2016, 1:29 PM
sebas added a reviewer: sebas.
In D2219#42920, @drosca wrote:

Can we expect canberra to be available everywhere PA is?

KF5 kmix has it as non-optional dependency too, so I think that should not be issue.

Okay, I think it's OK then.

This revision is now accepted and ready to land.Jul 28 2016, 1:29 PM
This revision was automatically updated to reflect the committed changes.