Differential D22184

[mobile/wifi] Improve connection removal drawer
ClosedPublic
Actions

Authored by nicolasfella on Jul 1 2019, 11:10 AM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
VDG
Commits
R116:e0bb4a4e144b: [mobile/wifi] Improve connection removal drawer
Summary

The code was overly complex and produced a few warnings.
The appearance mostly stays the same, except the drawer isn't as high as before

Test Plan

Before:

After:

The weird drawer placement seems to be an unrelated issue

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 1 2019, 11:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 1 2019, 11:10 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 1 2019, 11:10 AM
nicolasfella edited the test plan for this revision. (Show Details)Jul 1 2019, 11:12 AM
jgrulich accepted this revision.Jul 1 2019, 11:23 AM
This revision is now accepted and ready to land.Jul 1 2019, 11:23 AM
Closed by commit R116:e0bb4a4e144b: [mobile/wifi] Improve connection removal drawer (authored by nicolasfella). · Explain WhyJul 1 2019, 12:25 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Jul 1 2019, 6:37 PM

Also, these buttons should be in a RowLayout, not a Column.

Revision Contents
Changeset List

Diff 60919

View Options

mobile/wifi/package/contents/ui/NetworkListView.qml

Loading...