+1 for porting to use the correct Kirigami paradigm.

I feel like trying to do this exposes problems with our general style (toggle-able toolbar button don't have a special appearance to indicate this) as well as the "floating text-less button" paradigm for mobile (same problem, plus the lack of text makes it even harder to tell what it's going to do for semi-complex actions). I won't block it, but the matter might require more discussion.

In D22179#488748, @ngraham wrote:

+1 for porting to use the correct Kirigami paradigm.

I feel like trying to do this exposes problems with our general general style (toggle-able toolbar button don't have a special appearance to indicate this) as well as the "floating text-less button" paradigm for mobile (same problem, plus the lack of text makes it even harder to tell what it's going to do for semi-complex actions). I won't block it, but the matter might require more discussion.

I agree. I'm not particularly happy with the current solution

I kind of feel like on mobile, the toolbar itself should just move to the bottom. No need to use a whole new paradigm of floating text-less buttons that obscure the content and don't have labels. I know this is basically copied from Android, but I don't really like it there either. It just seems like an over-complicated and over-designed solution to a simple problem.

Anyway, I'll shut up now, and we should have that discussion somewhere else, not in the comments section of your patch here. :)