Differential D22178

[mobile/wifi] Fix some qml warnings in ConnectionItemDelegate
ClosedPublic
Actions

Authored by nicolasfella on Jun 30 2019, 9:21 PM.

Details

Reviewers
bshah
jgrulich
mkacej
Group Reviewers
Plasma
Commits
R116:6577c32f039d: [mobile/wifi] Fix some qml warnings in ConnectionItemDelegate
Summary

Using anchors on items managed by layouts is undefined behaviour.

This fixes a few warnings and also improves the visual appearance

Test Plan

On the desktop before:

On the desktop after:

On the phone before:

On the phone after:

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jun 30 2019, 9:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 30 2019, 9:21 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jun 30 2019, 9:21 PM
nicolasfella edited the test plan for this revision. (Show Details)Jun 30 2019, 9:24 PM
jgrulich accepted this revision.Jul 1 2019, 5:29 AM
This revision is now accepted and ready to land.Jul 1 2019, 5:29 AM
Closed by commit R116:6577c32f039d: [mobile/wifi] Fix some qml warnings in ConnectionItemDelegate (authored by nicolasfella). · Explain WhyJul 1 2019, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60906

View Options

mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml

Loading...