Differential D22177

Panel: Improve open actions in context menu
ClosedPublic
Actions

Authored by abika on Jun 30 2019, 6:11 PM.

Details

Reviewers
nmel
asensi
Group Reviewers
Krusader
Commits
R167:9dbf631ba7f1: Panel: Improve open actions in context menu
Summary

Minor improvement for the panel context menu

  • folders are not opened if multiple files are selected
  • multiple folders can be opened in new tabs
Test Plan

Tested context menu entries for selecting

  • one file
  • multiple files
  • one dir
  • multiple dirs
  • files and dirs

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika requested review of this revision.Jun 30 2019, 6:11 PM
abika created this revision.
abika added a project: Krusader.Jun 30 2019, 6:11 PM
abika added a subscriber: Krusader.
yurchor added a subscriber: yurchor.Jun 30 2019, 7:07 PM

Tested to work as expected.

+1

nmel accepted this revision.Jul 1 2019, 6:32 AM
nmel added a subscriber: nmel.

Reviewed the code and tested — everything is great!

This revision is now accepted and ready to land.Jul 1 2019, 6:32 AM
nmel added a comment.Jul 13 2019, 7:04 AM

Reminder for git push :)

asensi added a subscriber: asensi.Jul 18 2019, 9:36 PM

The new code works as expected using Kubuntu 18.04. Thanks, Alex! (and Yuri and Nikita :-) )

asensi accepted this revision.Jul 19 2019, 10:32 PM
Closed by commit R167:9dbf631ba7f1: Panel: Improve open actions in context menu (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyJul 21 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.Jul 21 2019, 4:18 PM

Thanks for testing again!

Revision Contents
Changeset List

PathPackages
Mkrusader/Panel/panelcontextmenu.cpp (84 lines)

Diff 62206

View Options

krusader/Panel/panelcontextmenu.cpp

Loading...