Differential D22174

Synchronizer: Set column headers to adjust widths automatically
ClosedPublic
Actions

Authored by abika on Jun 30 2019, 5:03 PM.

Details

Reviewers
asensi
Group Reviewers
Krusader
Commits
R167:0a5503a9792a: Synchronizer: Set column headers to adjust widths automatically
R167:fc2090be0866: Synchronizer: Set column headers to adjust widths automatically
Summary

The user cannot resize the columns width anymore.

FIXED: [ 167410 ] synchronize directory window: column widths are incorrect
BUG: 167410

Test Plan

Tested correct behaviour for

  • (re-)opening Synchronizer maximized and with custom size
  • changing column order

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika requested review of this revision.Jun 30 2019, 5:03 PM
abika created this revision.
abika added a project: Krusader.Jun 30 2019, 5:04 PM
abika added a subscriber: Krusader.
yurchor added a subscriber: yurchor.Jul 3 2019, 5:02 PM

Works fine for me (3-day testing). Thanks.

+1

asensi accepted this revision as: asensi.Jul 19 2019, 10:27 PM
asensi added a subscriber: asensi.

The new code works using Kubuntu 18.04. Although the final behavior of Synchronizer is not perfect, the patch improves the current situation, therefore: thanks, Alex! (and Yuri :-) )

This revision is now accepted and ready to land.Jul 19 2019, 10:27 PM
nmel added a subscriber: nmel.Jul 21 2019, 6:10 AM

If you'd like this fix to be included into v2.7.2, please merge by the end of the month.

Closed by commit R167:0a5503a9792a: Synchronizer: Set column headers to adjust widths automatically (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyJul 21 2019, 3:57 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.Jul 21 2019, 3:59 PM

Thanks for testing everyone!

Revision Contents
Changeset List

Diff 62205

View Options

krusader/Synchronizer/synchronizergui.h

Loading...
View Options

krusader/Synchronizer/synchronizergui.cpp

Loading...