Add option to disable OSD on volume change
AbandonedPublic

Authored by drosca on Jul 19 2016, 10:26 AM.

Details

Reviewers
None
Group Reviewers
Plasma: Design
Plasma
Summary

BUG: 363983

Test Plan

I'm not really sure on the label "Show OSD" as that may not be
clear to user what it is, better ideas?

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
osd-option (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
drosca updated this revision to Diff 5295.Jul 19 2016, 10:26 AM
drosca retitled this revision from to Add option to disable OSD on volume change.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 19 2016, 10:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Does it make sense to add an option for this to the plasmoid? If there is a need to disable osds, shouldn't we rather do it globally and disable all osd?

I think there already is global option to disable OSD, but I think it makes sense to just disable OSD for volume. Also kmix has this option and there are users that want it.

In D2217#41086, @drosca wrote:

I think there already is global option to disable OSD, but I think it makes sense to just disable OSD for volume. Also kmix has this option and there are users that want it.

I'm not sure. Where's the difference to screen brightness or changing keyboard layout? Why does audio volume need a dedicated option for it?

Anyway please add VDG to the review.

I agree with Martin: Either people want to see an OSD when changing a parameter using the keyboard, or they don't.
Like Martin, I don't see why someone would want an OSD when changing screen brightness with the keyboard, but not when changing volume.

Would it be possible to link to the KCM where OSDs can be configured from the volume applet settings? That would make it easier for people who are only annoyed by the volume OSD to find the setting...

See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771

What I could imagine is having a list of check boxes there:
"Show visual feedback for:"

  • [ ] Volume change
  • [ ] Brightness change
  • etc

but then I don't think we should do that.

See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771

What I could imagine is having a list of check boxes there:
"Show visual feedback for:"

  • [ ] Volume change
  • [ ] Brightness change
  • etc

That looks like a way better way to do it, if we decide for it.

drosca abandoned this revision.Jul 19 2016, 11:27 AM

That looks like a way better way to do it, if we decide for it.

Agree

How about we keep it as one option and only add more fine-grained controls of users demand it?

If we want to do fine-grained options right away, it should be hidden behind an "Advanced" expander (see https://techbase.kde.org/Projects/Usability/HIG/Settings ), since it's only a corner-case which can be safely ignored by most users.