Differential D22160

Document tree view close on middle button
ClosedPublic
Actions

Authored by tristanp on Jun 30 2019, 7:33 AM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:4b5ff487f926: Document tree view close on middle button
Summary

KDevDocumentView::mousePressEvent handles middle button over
document to close them quickly.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tristanp created this revision.Jun 30 2019, 7:33 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 30 2019, 7:33 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
tristanp requested review of this revision.Jun 30 2019, 7:33 AM
apol accepted this revision.Jun 30 2019, 8:28 AM
This revision is now accepted and ready to land.Jun 30 2019, 8:28 AM
kossebau added a subscriber: kossebau.Jul 8 2019, 12:41 PM

@tristanp Hi. You do not have push rights for KDE code reposistories, correct? So someone else would need to push for you then. Okay to extend your author name in the commit message to "Tristan Porteries"?

tristanp added a comment.Jul 8 2019, 2:58 PM

I'm okay for the name, thanks a lot for the review and futur commit

anthonyfieroni added a subscriber: anthonyfieroni.Jul 8 2019, 5:07 PM
anthonyfieroni added inline comments.
plugins/documentview/kdevdocumentview.cpp
109

Looks incorrect actionClose || actionOpen

tristanp updated this revision to Diff 61355.Jul 8 2019, 5:14 PM
  • Fix action boolean.
Closed by commit R32:4b5ff487f926: Document tree view close on middle button (authored by tristanp, committed by kossebau). · Explain WhyJul 9 2019, 8:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61394

View Options

plugins/documentview/kdevdocumentview.cpp

Loading...