Document tree view close on middle button
ClosedPublic

Authored by tristanp on Jun 30 2019, 7:33 AM.

Details

Summary

KDevDocumentView::mousePressEvent handles middle button over
document to close them quickly.

Diff Detail

Repository
R32 KDevelop
Branch
close_document_tree
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13416
Build 13434: arc lint + arc unit
tristanp created this revision.Jun 30 2019, 7:33 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 30 2019, 7:33 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
tristanp requested review of this revision.Jun 30 2019, 7:33 AM
apol accepted this revision.Jun 30 2019, 8:28 AM
This revision is now accepted and ready to land.Jun 30 2019, 8:28 AM

@tristanp Hi. You do not have push rights for KDE code reposistories, correct? So someone else would need to push for you then. Okay to extend your author name in the commit message to "Tristan Porteries"?

I'm okay for the name, thanks a lot for the review and futur commit

anthonyfieroni added inline comments.
plugins/documentview/kdevdocumentview.cpp
109

Looks incorrect actionClose || actionOpen

tristanp updated this revision to Diff 61355.Jul 8 2019, 5:14 PM
  • Fix action boolean.
This revision was automatically updated to reflect the committed changes.