Check for DQT_NO_CAST_FROM_BYTEARRAY
ClosedPublic

Authored by astippich on Jun 30 2019, 7:10 AM.

Details

Summary

add the build flag and fix all errors

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Jun 30 2019, 7:10 AM
Restricted Application added a project: Baloo. · View Herald TranscriptJun 30 2019, 7:10 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
astippich requested review of this revision.Jun 30 2019, 7:10 AM
astippich added inline comments.Jun 30 2019, 7:11 AM
src/filemetadataprovider.cpp
519

disclaimer: I don't know why it was added like this before, but using the way it is done in windows seems to work just fine.

bruns added inline comments.Jun 30 2019, 10:57 AM
src/filemetadataprovider.cpp
519

very likely for performance/memory reasons.

This should at least use a QDirIterator, otherwise entryList(...) will allocate a lot of memory for large directories.

Please create a directory with 10000 entries and benchmark all variants.

astippich updated this revision to Diff 60881.Jun 30 2019, 5:59 PM
  • bring back openly coded counting
astippich added inline comments.Jun 30 2019, 6:00 PM
src/filemetadataprovider.cpp
519

You were right.
Benchmark showed that QDir is about 10x slower, file QDirIterator still around 5x, so I've added it back.

astippich edited the summary of this revision. (Show Details)Jun 30 2019, 6:01 PM
bruns accepted this revision.Jun 30 2019, 7:27 PM
This revision is now accepted and ready to land.Jun 30 2019, 7:27 PM
This revision was automatically updated to reflect the committed changes.