Disable sRGB rendering when the color encoding of the default
framebuffer is linear.
BUG: 408594
Details
Details
- Reviewers
zzag - Group Reviewers
KWin - Commits
- R108:5191311d36fb: [effects/blur] Disable sRGB when the framebuffer is linear
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| effects/blur/blur.cpp | ||
|---|---|---|
| 133 | Do we need to check whether the default framebuffer object is bound? | |
| 137–138 | Coding style nitpick: Use curly braces even when the body of a conditional statement contains only one line. | |
| 656 | Do we have to worry about the looking glass effect and all other effects that render the scene to a texture? | |
| effects/blur/blur.cpp | ||
|---|---|---|
| 656 | And the reason is that GLRenderTarget::blitFromFramebuffer() always blits from the default framebuffer. | |
| effects/blur/blur.cpp | ||
|---|---|---|
| 656 | Aye, the source framebuffer object is hard coded. | |
| effects/blur/blur.cpp | ||
|---|---|---|
| 656 | I suggest that we ignore this issue in the stable branch for now since this is not a regression. I don't want to risk further fallout by changing the behavior of blitFromFramebuffer() there. That this has been broken for a very long time without anyone noticing also speaks volumes about how many people use the looking glass effect. | |
| effects/blur/blur.cpp | ||
|---|---|---|
| 134 | Please use reinterpret_cast instead of c-style cast. | |
Comment Actions
I actually don't like that practice, because parts of the git tool chain automatically strips leading bracketed strings from commit messages.
These are used to encode information that's not supposed to be in the final commit message, such as [PATCH 1/2].
Comment Actions
I actually don't like that practice,
So do I to be honest. I prefer foobar: Heart touching subject line style. [foobar] is predominant style, that's why I asked you to change the prefix.